Error with expr - "expr: syntax error"


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting Error with expr - "expr: syntax error"
# 1  
Old 02-23-2012
Error with expr - "expr: syntax error"

Hi All,

I'm writing a shell script in KSH, where I want to store the filename, total record count and actual record count of all the source files. The source files reside in 4 different sub-folders under the same root folder.

Below is code:
Code:
 
#!/usr/bin/ksh
common_path_in="/interface_in/rsc"
file_out="/interface_in/rsc/record_count.csv"
tot_rec_count=-1
act_rec_count=-1
echo ${common_path_in}
echo ${file_out}
echo ${tot_rec_count}
echo ${act_rec_count}
set -A folders horizon mysteryshopper rcc reference
echo ${folders[@]}
for i in ${folders[@]}
do
        ls -1 ${common_path_in}/$i/*.csv | xargs -n1 basename | while read filename
        do
                tot_rec_count=`wc -l ${common_path_in}/$i/*.csv | cut -f1 -d' '`
                echo ${tot_rec_count}
                act_rec_count=`expr ${tot_rec_count} - 1`
                echo ${act_rec_count}
                #echo "$filename,${tot_rec_count},${act_rec_count}" >> ${file_out}
        done
done

I'm getting output till the folder names, after that getting "expr: syntax error", for number of source files I've.

Surprisingly among these errors only once I'm getting correct count outputs for the case, where the source folder contains only single data file.

I've done the coding in vi editor and have not used MS editor.

Please suggest.

Regards,
Jagari
# 2  
Old 02-23-2012
I doubt this works:
Code:
tot_rec_count=`wc -l ${common_path_in}/$i/*.csv | cut -f1 -d' '`

(cant test now...)

I would do it like this:
Code:
tot_rec_count=$(ls -1 $common_path_in/$i/*.csv|wc -l )
let act_rec_count=$tot_rec_count-1

# 3  
Old 02-23-2012
Once your "wc -l" line found more than one file it output more than one line and a "total" line.
Assuming that you want to process file-by-file:
Code:
       ls -1 ${common_path_in}/$i/*.csv | while read filename
        do
                tot_rec_count=`wc -l "${filename}" | cut -f1 -d' '`

This User Gave Thanks to methyl For This Post:
# 4  
Old 02-23-2012
I wanted to add : The while loop puzzles me...
What is expected?

I dont get your logic: Once your are reading A (yes 1!) filename what is the point to go through all this strange calculation and no storing of $filename (???), I may be (quite sure..) very tired today but I am missing something there...
# 5  
Old 02-23-2012
Hi Methyl,

Thanks, you identified the right point.
The problem was with -
Code:
 
tot_rec_count=`wc -l ${common_path_in}/$i/*.csv | cut -f1 -d' '`

It worked correctly with $filename as you suggested.
Then I've modified that portion as below -
Code:
 
ls -1 ${common_path_in}/$i/*.csv | xargs -n1 basename | while read filename
        do
            echo "${filename}"
            tot_rec_count=`wc -l "${common_path_in}/$i/${filename}" | cut -f1 -d' '`

It's now working properly.

But I've few doubts, would be great if you could answer -
1. The usage of curly braces {} and " " in displaying variable value - when we use which one?
2. use of back quote in value assignment to a variable and with expr command. For eg, the way I'm assigning tot_rec_count.

Thanks,
Jagari
# 6  
Old 02-23-2012
1. The usage of curly braces {} and " " in displaying variable value - when we use which one?
echo "${filename}"
I have got into the habit of always putting quotes round string variables and strings because it prevents so many silly errors when a value contains spaces.
I have also got into the habit of using curly braces even when they are not strictly necessary because it makes the variable name totally unambiguous.
It also prevents errors like this:
Code:
# Didn't recognise variable
fred="abc"
echo $fred42
sh: fred42: Parameter not set.

# Spaces disappeared
fred="abc"
echo ${fred}42     displaced
abc42 displaced

# All working now. Spaces not lost
fred="abc"
echo "${fred}42     displaced"
abc42     displaced

2. use of back quote in value assignment to a variable and with expr command. For eg, the way I'm assigning tot_rec_count.
Quote:
act_rec_count=`expr ${tot_rec_count} - 1`
In ksh and Posix Shell whatever is between backticks is to be executed.
This more modern syntax is preferred. $((arithmetic)).
Code:
act_rec_count=$((${tot_rec_count} - 1))



Also, I wouldn't bother with an array.
Quote:
set -A folders horizon mysteryshopper rcc reference
echo ${folders[@]}
for i in ${folders[@]}
This works the same and imho is easier to read and easier to type:
Code:
for i in "horizon" "mysteryshopper" "rcc" "reference"

This User Gave Thanks to methyl For This Post:
# 7  
Old 02-24-2012
Thanks Smilie it's really very helpful.

Regards,
Jagari

---------- Post updated at 10:25 AM ---------- Previous update was at 10:23 AM ----------

The while loop reads each filename and then counts the number of records in each of them. As the files have a header record, the count is decreased by 1 to get the actual number of records.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Expr: non-numeric argument syntax error on line 1, teletype

Hi, I tried to look up the issue i'm experiencing, but i'm confused what's wrong with my script. After executing the script I'm getting the following error expr: non-numeric argument syntax error on line 1, teletype After some research, it seems that the problem relates to bc. I have... (1 Reply)
Discussion started by: nms
1 Replies

2. Shell Programming and Scripting

Commenting out "expr" creates weird behavior

This really puzzles me. The following code gives me the error 'expr: syntax error' when I try to do multi-line comment using here document <<EOF echo "Sum is: `expr $1 + $2`" EOF Even if I explicitly comment out the line containing the expr using "#", the error message would still exist... (3 Replies)
Discussion started by: royalibrahim
3 Replies

3. Homework & Coursework Questions

How to lclear "expr: syntax error" eventhough everything looks fine?

Hi All, As per my knowledge in unix, my code looks fine. But still I am getting error (expr:syntax error). Please help me to resolve this error. Script : PRE_LBNO=0 PRE_DATE=0 TOT_PAY=0 TOT_REM=0 TOTAL=1 for Record_Type in `cut -c 1 Inputt.dat` do if ; then CURR_LBNO=` cut -c... (6 Replies)
Discussion started by: lathanandhini
6 Replies

4. UNIX for Dummies Questions & Answers

expr: syntax error

Hi All, This is a piece of code from one of my scripts: t1=`cat temp3.21447 | grep WEALTHTOUC_TRANS_20100409_233127.txt.txt.TRG | awk '{print $3}' | cut -c1-5` t2=`cat temp3.21447 | grep WEALTHTOUC_TRANS_20100409_233127.txt.txt.TRG | awk '{print $5}' | cut -c1-5` #t1=23:43... (5 Replies)
Discussion started by: prachiagra
5 Replies

5. UNIX for Dummies Questions & Answers

expr - Syntax error

hello to everyone, i am writing a shell script in unix and i use the following command: lnum= cut -f 1 -d : aa passline=`expr $lnum + 1` echo "$passline" with the following command i get the value that is stored in the first field of the file "aa" and i save it in the variable "lnum". i am... (2 Replies)
Discussion started by: omonoiatis9
2 Replies

6. Shell Programming and Scripting

convert a=(b/100)*a into a "expr" expression

Hi Guys, THis is the first time am using the expr expression. I like to know how to write the expression a=(b\100)*a. THis works fine if it gives without a bracket. the bracket should be present as i wanted to define the order of execution. Help me out. Thanks for your help in advance.... (2 Replies)
Discussion started by: mac4rfree
2 Replies

7. Shell Programming and Scripting

HowTo: reg expr doing grep "timestamp>$DesiredTime" logfile ?

I know I asked a similar question but I want to know if there is a regular expression existing that with a korn shell cmd, finds any timestamp data records in a file where it is greater then a timestamp in a shell variable ? something like : grep all records where it has a timestamp >... (5 Replies)
Discussion started by: Browser_ice
5 Replies

8. Shell Programming and Scripting

"syntax error at line 21 :'done' unexpected." error message"

I am trying to run the script bellow but its given me "syntax error at line 20 :'done' unexpected." error message" can someone check to see if the script is ok? and correct me pls. Today is my first day with scripting. Gurus should pls help out #!/bin/ksh # Purpose: Check to see if file... (3 Replies)
Discussion started by: ibroxy
3 Replies

9. Shell Programming and Scripting

why "expr "${REPLY}" : '\([1-9][[:digit:]]*\)" can figure out whether it is a digit?

I found below script to check whether the variable is a digit in ksh. ############################ #!/bin/ksh REPLY="3f" if ]*\)'` != ${REPLY} && "${REPLY}" != "0" ]] then print "is digit\n" else print "not digit\n" fi ############################ Although it works fine, but... (6 Replies)
Discussion started by: sleepy_11
6 Replies

10. Shell Programming and Scripting

expr: syntax error. why?

i want to get a substring from a string and used such shell script: var_year=`expr substr "07132006" 5 4` echo $var_year but i got such error message: expr: syntax error. why? Note: Kshell used on solaris 8. :confused: (5 Replies)
Discussion started by: robin.zhu
5 Replies
Login or Register to Ask a Question