Array output through a for loop problematic with multiple elements.
This code works perfect when using a machine with only one interface online. (Excluding the loopback of course) But when I have other interface up for vmware or a vpn the output gets mixed up. I know I had this working when I was just reading ip's from files so I know it is not a problem with nmap, even though it feeds back the error. Any help much appreciated.
Code:
#!/bin/bash
x=5.21
zero+=( "$(/sbin/ifconfig | grep "inet addr" | awk '{ print $2 }' | sed -e '/127.0.0.1/d' | cut -c6- | sed 's/.[^.]*$//' | uniq)" )
v=`nmap --version | grep "Nmap" | awk '{ print $3 }'`
for i in "${zero[@]}"
do
if [ $v == $x ]; then
one+=( "$(nmap -sP $i.0/24 | grep report | awk '{ print $5 }')" )
sleep 1
else
one+=( "$(nmap -sP $i.0/24 | grep Host | awk '{ print $2 }')" )
sleep 1
fi
done
y=0
length=${#one[@]}
for (( z = 0; z < $length; z++ ));
do
echo -e "${one[$y]}\n"
done
By the way. I have only tested this with nmap 5.00 and 5.21. It may not work at all on other versions.
Um... That's not what I want to do. I should have been more specific, but I'm trying to get all the interfaces (Minus loopback), store them in array zero, then output them one at a time through the loop. Otherwise I wouldn't have bothered making an array. But thanks for trying
uniq requires that its input be sorted. The order of ip addresses generated by that command is likely to not be properly sorted. Even if it happens to be, it may not be guaranteed.
While it's harmless in this instance, the sed regular expression is probably more promiscuous than intended. The unescaped, leading dot is matching anything, not just a dot.
The grep|awk|sed|cut|sed|sort|uniq pipeline can be replaced by a single awk invocation:
Although a single awk invocation is more efficient, unless a large amount of data is being processed, the performance gain is of no importance. Naturally, that awk will give incorrect results if the equivalent pipeline it replaces is itself incorrect.
The following is a clumsy way to iterate over a bash array.
Quote:
Originally Posted by Azrael
Code:
y=0
length=${#one[@]}
for (( z = 0; z < $length; z++ ));
do
echo -e "${one[$y]}\n"
done
Beyond that, it seems that y should be z or z should be y. y is never incremented in that loop. While the loop will execute once array member, it will invariably return the first the zeroth member. A simpler, more natural approach that would never have led to that bug:
Code:
for i in "${one[@]}";
do
echo -e "$i\n"
done
Hopefully, something in this post is of some use to you. If not, provide us with more information such as your platform/operating system, sample output from the commands you're running (your ifconfig may not be the same as another's), and the problematic output versus the desired output ("the output gets mixed up." isn't at all helpful).
Hopefully, something in this post is of some use to you. If not, provide us with more information such as your platform/operating system, sample output from the commands you're running...
Debian Linux (Squeeze & Sid)
Quote:
The grep|awk|sed|cut|sed|sort|uniq pipeline can be replaced by a single awk invocation:
I noticed what you said was true with the loop. I thought it was odd, but some site showed me to do it like that while outputting array elements. I changed everything to y and I piped through sed to remove 127.0.0.1 again and...
Previously, I simply pointed out what stood out without giving the purpose of your code much thought. I seldom use linux (or bash), so after googling for a sample of linux's ifconfig output, here's how I'd do what I think you're trying to do:
Code:
#!/bin/sh
if [ 5.21 = $(nmap --version | awk '/Nmap/ { print $3 }') ]; then
i=5 t=report # field index and target text
else
i=2 t=Host
fi
/sbin/ifconfig | awk '/inet addr/ && !/127.0.0.1/ && !a[$2]++ {print substr($2,6)}' |
while read ip; do
nmap -sP ${ip%.*}.0/24 | awk 'index($0,t) { print $i }' t="$t" i="$i"
sleep 1
done
The ifconfig|awk pipe feeding the while loop should output full ip addresses (all 4 octets) one per line. ${ip%.*}.0/24 strips the final octet and replaces it with 0 and the /24 cidr prefix.
If that doesn't work, then perhaps someone who has linux and nmap handy can help.
Regards,
Alister
---------- Post updated at 04:46 AM ---------- Previous update was at 04:32 AM ----------
In my first post, $2!="127.0.0.1" isn't eliminating the loopback address because it's trying to match an entire field whose value is that ip address. It didn't take into account that in the linux ifconfig output, the actual value of $2 would be addr:127.0.0.1.
Hi All,
need help with reading the array and sum of the array elements.
given an array of integers of size N . You need to print the sum of the elements in the array, keeping in mind that some of those integers may be quite large.
Input Format
The first line of the input consists of an... (1 Reply)
while IFS= read -r line
do
# sV for version detection
nmap -T4 -Pn -v -sS "$line" > "text/$line"
done < <(grep '' $file)
Hi,
where line represents the IP.
I am using NMAP to do scanning.
How can I set to execute that command in the loop several concurrently at a time instead of one... (5 Replies)
Hi everyone, :)
I'm trying to make a simple C program that scans an array of chars to see if its elements are similar.
I can't understand what's wrong. Could you help me to fix this? Here is the code.
Thanks!
#include<stdio.h>
int main() {
int arr;
int i, len;
int flag =... (10 Replies)
Hi,
I can't find out how to create correct code to get multiplication of each elements of array. Let's say I enter array into command line (2 3 4 5 6 8) and i need output 2*3*4*5*6*8=5760.
I tried this one, but answer is 0.
for i in $@; do
mult=$((mult*i))done
echo "mult: " $mult
... (4 Replies)
I have a script which takes backup of some configuration files on my server. It does that by using an array which contains the complete path to the files to backup.
It copys the files to a pre defined dir. Each "program" has it's own folder, ex. apache.conf is being copied to /predefined... (7 Replies)
Hi I have two arrays :
@arcb= (450,625,720,645);
@arca=(625,645);
I need to remove the elements of @arca from elements of @arcb so that the content of @arcb will be (450,720).
Can anyone sugget me how to perform this operation?
The code I have used is this :
my @arcb=... (3 Replies)
Have built this script, the output is what I needed, but NR 6 is omitted. Why? Is it an error? I am using Gawk.
'{nr=$2;f = $1} END{for (i=1;i<=f;i++) if (nr != i) print i, nr }' input1.csv >output1.csvinput1.csv
1 9
3 5
4 1
7 6
8 5
10 6
output1.csv > with the missing line number 6. 6 is... (5 Replies)
Hi,
My doubt is how to access array elements..
Situation is as below:
#!/bin/ksh
set -x
typeset -i x=0
typeset -i y=0
typeset -i BID=0
typeset -i count=0
while ] ; do
x=`expr $x + 1`;
hwmgr show scsi > scsi.tmp
while read line; do
set... (1 Reply)
09-30-2011
