While loop error


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting While loop error
# 1  
Old 08-19-2011
While loop error

I have a while loop in my script that works most times, but has generated an error once that has me a bit confused. I'm using ps to grab the runtime of a backgrounded command, and testing it to maintain the loop.

If I test this on its own, I run into no problems, but during one use of the script I recieved the error: line 293 '[' '14:13' unary operator expected.

Code:
scriptRUNTIME=`ps -eo uid,pid,etime | grep $! | awk '{print $3}'` 

while [ $scriptRUNTIME > 0 ] #this was line 293

do
     some stuff
     scriptRUNTIME=`ps -eo uid,pid,etime | grep $! | awk '{print $3}'`
     echo $scriptRUNTIME "minutes elapsed"
done

Would it instead, be better to evaluate this as:

Code:
while [ -n $scriptRUNTIME ]

or

Code:
while [ $scriptRUNTIME -gt 0 ]

# 2  
Old 08-19-2011
-n is closer to what you want, but a lot of that pipe chaining in backticks is pointless since you know the PID. Just watch if /proc/pid still exists, each running process gets a directory inside /proc/.

Code:
# keep looping while the process still exists
while [ -d /proc/$! ]
do
        do stuff
done

This User Gave Thanks to Corona688 For This Post:
# 3  
Old 08-19-2011
Try this:
Code:
while [ "$scriptRUNTIME" -gt 0 ] #this was line 293

# 4  
Old 08-19-2011
I would use the simpler method of checking /proc, but the directory doesn't exist in OS X.

I'll try -n and see if that resolves the error.
thanks!
# 5  
Old 08-19-2011
Quote:
Originally Posted by reid
I would use the simpler method of checking /proc, but the directory doesn't exist in OS X.
I had to check but wow, you're right. Next time someone says OSX is just like any other UNIX underneath I can give them that.


This is why it's always a good idea to say what your system is in your first post, so we don't have to play the strange combination of 20-questions and pin-the-tail-on-the-donkey that is finding answers to questions here. Smilie
Quote:
I'll try -n and see if that resolves the error.
Be sure to quote the string. No quotes means [ -n $STUFF ] becomes [ -n ] which is a syntax error. [ -n "$STUFF" ] becomes [ -n "" ] which is okay.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Error with for loop

There are two files abc_123.dat and abc_345.dat if at least one file exists then enter into the loop and remove file and exit. In first iteration, deleting files successfully but "else" statement executing after deleting files."else" should execute only if there is no file in the directory.... (1 Reply)
Discussion started by: Rajesh123
1 Replies

2. Shell Programming and Scripting

Error in for loop

I was trying to implement a nested for do loop to run a perl script. for i in 1 10 50 do for j in 2 12 55 do perl script.pl "$i" "$i" "$j" done done when I implemented it within a shell script, i got the output, but every time j value will 55, or basically the last value of j in... (10 Replies)
Discussion started by: Kanja
10 Replies

3. Shell Programming and Scripting

Error in loop

This is my first ever bash script. What i wish to achieve is to find all files in current directory except the script file and count lines in each found file. Some thing seems to be wrong with the if statement :confused: Please help why it does not work? and maybe you have some ideas how to improve... (3 Replies)
Discussion started by: chinababy
3 Replies

4. Shell Programming and Scripting

Getting error in if loop

Hi All, while executing this code ,I'm gettign below Error if_test: line 3: #!/bin/bash if ; then echo "this is aginity;" elif ; then echo "this is informatica;" fi exit (3 Replies)
Discussion started by: netdbaind
3 Replies

5. Shell Programming and Scripting

Error in while loop

I have a file Table.out having table name like this Table_Emp Table_Exp Table_Fcr To show first 10 rows .. I' wrtng a script like this .. #!/bin/ksh cat /tmp/table.out|while read -r table vbar1 do <connect to db> then select * from $table limit 10; > /tmp/1.out done ... (3 Replies)
Discussion started by: netdbaind
3 Replies

6. Shell Programming and Scripting

Error with while loop

the program just prints all the command line arguments Getting error in the program error ./hellow: line 13: 0: command not found ./hellow: line 13: 0: command not found below is the program #!/bin/bash num=$# echo $num if then echo "No arguments are passed ." else ... (7 Replies)
Discussion started by: BHASKARREDDY006
7 Replies

7. Shell Programming and Scripting

Error Using an if Loop Within a While Loop

Hello All, I am having a problem with an “if loop” within a “while loop” in my Korn Shell program. The basic concept of the program is that it searches for the existence of a series of load files in a load directory, and once it finds one of these files, it begins the following process: · Creates... (4 Replies)
Discussion started by: jonesdk5
4 Replies

8. UNIX for Dummies Questions & Answers

error in for loop???

Hi, I get the following output 98 -1 98 0 ./get_AB04-time: line 79: ((: i< && 0 !=7 : syntax error: operand expected (error token is "&& 0 !=7 ") I have this part of code. Line 79 is the line of the for loop. echo ${OCCURRENCE} $i_START CASE=0; i_END=${i_START}... (4 Replies)
Discussion started by: f_o_555
4 Replies

9. Shell Programming and Scripting

Error in Loop?

hi friends, i wrote one simple shell script.. in that am using for loop... when i am trying to execute the script.it shows syntax error at for loop line '((' unexpected. #!/bin/ksh ## ##### To find no of files in the directory NOF=`ls -l /root/COMM/LOGS/eds/20081025| wc -l`... (5 Replies)
Discussion started by: rdhaprakasam
5 Replies

10. UNIX for Dummies Questions & Answers

Error in for loop?

Hi, Working on AIX using the following for loop. for a in `find /edi/iTracTEST/sessions -name nohup.out -print` do echo $a done On the command line it works fine, but insert the code in a file and then running it, it does not want to work. I get the following back. ' is not... (3 Replies)
Discussion started by: hugow
3 Replies
Login or Register to Ask a Question