sed unterminated `s' command?


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting sed unterminated `s' command?
# 1  
Old 05-04-2010
sed unterminated `s' command?

Hi there,

I'm pretty new to this whole scripting thing. I've written myself something which takes my txt file of SMSes (the backup from the phone), and puts them into an email format, saving them as .eml files. I've tested and uploaded a batch to gmail, but because of threading issues, I've decided that I need to individualise the subject lines so that they display better. For reference, here's the code..

Quote:
#!/bin/bash

sed -i 's/^$/newlinenewlinenewline \n /g' test2.txt #marks where breaks originally occured
#editing From/To headers below
sed -i 's/3538|+3538/08/g' test2.txt ##standardises number format from +3538/3538 to 08....
sed -i 's/From: My Phone/From: ###/g' test2.txt #makes default "me" sender my number
sed -i 's/To: My Phone/To: ####/g' test2.txt #""
sed -i 's/+3538/08/g' test2.txt
sed -i 's/3538/08/g' test2.txt

sed -i 's/From: 08/From: <08/g' test2.txt #adds the "<" character to the address string
sed -i 's/To: 08/To: <08/g' test2.txt #adds the "<" character to the address string
sed -i '/From:/s|$|>|' test2.txt #adds the last ">" to the address string
sed -i '/To:/s|$|>|' test2.txt #adds the last ">" to the address string

#editing Date headers
sed -i 's/Received:.*\09//g' test2.txt
sed -i 's/Received:.*\0//g' test2.txt
sed -i 's/Sent: /Subject: SMS \nDate: /g' test2.txt

sed -i '/^$/d' test2.txt #deletes blank lines from previous removal of dates
sed -i 's/Text:/MIME-Version: 1.0 \nContent-Type: multipart\/alternative; \n boundary="----=_NextPart_000_000C_01CAE890.FD6A3090" \nX-Priority: 3 \nX-MSMail-Priority: Normal \nX-Unsent: 1 \nX-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 \n \nThis is a multi-part message in MIME format. \n \n------=_NextPart_000_000C_01CAE890.FD6A3090 \nContent-Type: text\/plain; \n charset="iso-8859-1" \nContent-Transfer-Encoding: quoted-printable \n \n------=_NextPart_000_000C_01CAE890.FD6A3090 \nContent-Type: text\/html; \n charset="iso-8859-1" \nContent-Transfer-Encoding: quoted-printable \n \n<!DOCTYPE HTML PUBLIC "-\/\/W3C\/\/DTD HTML 4.0 Transitional\/\/EN"> \n<HTML><HEAD> \n<META http-equiv=3DContent-Type content=3D"text\/html; = \ncharset=3Diso-8859-1"> \n<META content=3D"MSHTML 6.00.2900.5945" name=3DGENERATOR> \n<STYLE><\/STYLE> \n<\/HEAD> \n<BODY bgColor=3D#ffffff> \n<DIV><FONT face=3DArial size=3D2>/g' test2.txt

sed -i 's/newlinenewlinenewline/<\/FONT><\/DIV><\/BODY><\/HTML>\n \n------=_NextPart_000_000C_01CAE890.FD6A3090--/g' test2.txt #returns breaks

sed -i 's/[ \t]*$//' test2.txt #removes whitespace, email errors otherwise.
awk '/From: /{n++}{print >"out" n ".eml" }' test2.txt #creates .eml files
My problem is such - I've added the following three lines to the code, and now I'm getting an "unterminated `s' command" no matter what I try...

Basically what I want to do is to take the 1st line of the .eml file, (the from: line), and the second line of the file (the to: line) and add them into the subject: line to individualise each one.

The code I tried was

Quote:
from1=$(head -n1 *eml)
to1=$(sed -n '2p' *eml)
sed -i "s/SMS/SMS $from to $to/g" *eml
But I can't see where I've gone wrong? Any ideas?
# 2  
Old 05-04-2010
Hello, donnacha, and welcome to the forums.

For starters, your variable names don't match up (from1 vs from, to1 vs to), although I don't think that's the source of the problem (perhaps that's just a typo in the post). I suspect that the problem is that the values of the from1 and to1 variables will contain multiple lines if there are multiple files that match the *eml pattern. The embedded newlines are almost certainly what is causing the problem with the sed command.

Perhaps something akin to the following will suit your needs:
Code:
for f in *eml; do
    sed -i "s/SMS/SMS $(head -n1 "$f") to $(sed -n '2p' "$f")/g" "$f"
done

Regards,
Alister
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. UNIX for Beginners Questions & Answers

Unterminated <> operator

Hello. I'm self teaching myself and coded a program but I keep getting a illegal division by 0 error. I know what it means but I don't know where I am messing up. Here is the code: #!/usr/bin/perl @lines = <>; my %earned; my %possible; for ($i = 1; $i <... (6 Replies)
Discussion started by: Eric7giants
6 Replies

2. UNIX for Beginners Questions & Answers

Sed: -e expression #1, char 20: unterminated address regex

I am trying to add word in last of particular line. the same command syntex is running on prompt. but in bash script give error."sed: -e expression #1, char 20: unterminated address regex" Please help. for i in `cat servername`; do ssh -q -t root@$i sed -i '/simple_allow_groups =/s/$/,... (4 Replies)
Discussion started by: yash_message
4 Replies

3. Shell Programming and Scripting

Sed: -e expression #1, char 16: unterminated address regex

I am trying to grep for a particular text (Do action on cell BL330) in a text file(sample.gz) which is searched in the content filtered by date+timestamp (2016-09-14 01:09:56,796 to 2016-09-15 04:10:29,719) on a remote machine and finally write the output into a output file on a local machine. ... (23 Replies)
Discussion started by: rbadveti
23 Replies

4. Shell Programming and Scripting

sed returns error "sed: -e expression #1, char 18: unterminated `s' command"

Hello All, I have something like below LDC100/rel/prod/libinactrl.a LAA2000/rel/prod/libinactrl.a I want to remove till first forward slash that is outputshould be as below rel/prod/libinactrl.a rel/prod/libinactrl.a How can I do that ??? (8 Replies)
Discussion started by: anand.shah
8 Replies

5. UNIX for Dummies Questions & Answers

sed error unterminated `s' command

I have list of data I have cut down to format: I am using sed command to remove the sed 's/ Returns error: sed: -e expression #1, char 5: unterminated `s' command Full code line is: cat textFile | cut -d ' ' -f 4 | cut ':' -f 1 | sed 's/ Thanks, Please use next time code tags... (2 Replies)
Discussion started by: maximus73
2 Replies

6. Shell Programming and Scripting

sed: -e expression #1, char 21: unterminated `s' command

I have read many threads, but I still didn't find the right answer. May be i didn't find the right thread, though are so many threads for the same question. Basically the situation is - find date in a file and replace it with another date. (its not homework, its part of lot of a big processing,... (10 Replies)
Discussion started by: avinthm
10 Replies

7. Shell Programming and Scripting

Unterminated quoted string

Hello! I wroted a little script that should check for new updates on a server and get them if any. The problem is, every time I run it with sh, I'm getting an "script: 20: Syntax error: Unterminated quoted string" error! The problem is, there isn't any "unterminated quoted string" in my script:... (2 Replies)
Discussion started by: al0x
2 Replies

8. Shell Programming and Scripting

[Solved] sed - query - unterminated suddenly

Hi, I have been trying to get various sed statements to work. I thought I had cracked it when suddenly I start recieving these messages "sed: -e expression #1, char 14: unterminated 's' command" It happens on any sed statement I now run. The only thing I have done inbetween trying to get... (0 Replies)
Discussion started by: mcclunyboy
0 Replies

9. Shell Programming and Scripting

Using SED command in a shell script: Unterminated address regex

Hi All, I am trying to use a sed command in a shell script in order to delete some lines in a file and I got the following error message. I don't understand why it is not working 'cause I have tried with simple quotes, then with double-quotes, and it is not working. sed: -e expression #1,... (7 Replies)
Discussion started by: Alpha3363
7 Replies

10. UNIX for Dummies Questions & Answers

Unterminated string

While running a shell script i am getting this warning but the script is working fine.while running the blocks of the scripts individually its running fine.But while pasting it combinedly this is the warning..wat may be the reason behind this and how to resolve it (3 Replies)
Discussion started by: dr46014
3 Replies
Login or Register to Ask a Question