What is wrong in my IF loop ??


 
Thread Tools Search this Thread
Top Forums Shell Programming and Scripting What is wrong in my IF loop ??
# 1  
Old 02-11-2010
What is wrong in my IF loop ??

What is wrong in my IF loop

Code:
if [ $1 -eq "0" && $2 -eq "0" ]
then
   echo " The request is authenticated "
fi

The error im getting is

Code:
$ ./routing.sh server enables

**********************************************************************
 Preparing to service the request for  Device server in Question
**********************************************************************

./routing.sh: line 46: [: missing `]'

USAGE
   routing.sh <server> <disable|enable>

# 2  
Old 02-11-2010
Code:
if [ $1 -eq 0 ] && [ $2 -eq 0 ];
then
   echo " The request is authenticated "
fi


Last edited by EAGL€; 02-11-2010 at 02:35 PM.. Reason: code tags :)
# 3  
Old 02-11-2010
Code:
if [ $1 -eq "0" -a $2 -eq "0" ]

# 4  
Old 02-11-2010
oops !! its my bad . The condition is when both the variable $1 $2 exit code is 0 it should display {Request Authenticated }. Since the above syntax is erroring out again

Code:
./routing.sh server123 enables

**********************************************************************
 Preparing to service the request for  Device Server123 in Question
**********************************************************************

./routing.sh: line 46: [: server123: integer expression expected

USAGE
   routing.sh <device> <disable|enable>

This is the variable condition, on which im verifying.

enable = exit code 0
enables = exit code 1

server123= exit code 0 [ Existing Server]
serverABC= exit code 1 [ Non Existing Server ]
# 5  
Old 02-11-2010
use double qoutes for $1 and $2
Code:
if [ "$1" -eq 0 ]&&[ "$2" -eq 0 ];
then

if $1 and $2 are strings which will not have integer values then try something like this:

Code:
if [ "$1" = "" ]&&[ "$2" = "" ]; then

# 6  
Old 02-11-2010
Im testing for 2 variables

1. Device
2. State <enable|disable>

Condition on which im testing is :

Condition 1
. Device name doesn't exist in hosts file . The corresponding output can been seen here. Conclusion : Satisfied. Displays desired output.
But should have excluded " Correct Input Parameters "

Code:
$ ./routing.sh server123 enable

**********************************************************************
 Preparing to service the request for  Device server123 in Question
**********************************************************************

 Correct Input Parameters
 Invalid Server Request

Condition 2 : Incorrect state parameter . The corresponding output can be seen here. Conclusion : Very Much Satisfied. Displaying the USAGE.

Code:
$ ./routing.sh Server24-ra enables

**********************************************************************
 Preparing to service the request for  Device Server24-ra in Question
**********************************************************************

 Correct Input Parameters

USAGE
   routing.sh <device> <disable|enable>

Condition 3 When both parameters are correct, still this " Correct Input Parameters " is being displayed , either it should have omitted when both variables are satisfying the condition on which they are assigned too.
Conclusion: Not Satisfied. Need to work on it.

Code:
$ ./routing.sh server24 enable

**********************************************************************
 Preparing to service the request for  Device server24 in Question
**********************************************************************

 Correct Input Parameters
 Enabling the Device in few seconds
 Report Logging . .

 Thu Feb 11 13:18:00 CST 2010

 FILE CREATED:  outFile100211-131800.server24.enable

 Global configuration mode
 admin  enabled
 Configuration saved successfully.
 Goodbye

*********************************************************************

But from above if loop changes its not being fully effective on the script, do we need to apply an elif statement here.
# 7  
Old 02-11-2010
Can you provide your code on how you are obtaining these variables?
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

What's wrong with this while loop?

function get_tablespace() { ## Get the current size of the tablespace size=`su -l oracle -c 'db-control report' |egrep "DATA_TBS" | awk '{print $5}'|tr -d '%'` ## Loop through until the size is 82 or less count=0 while && do ... (2 Replies)
Discussion started by: bille
2 Replies

2. Shell Programming and Scripting

What is wrong with my if loop?

Hello everyone, I need a little help. I wrote a cshell script to change the format of a file but it is not working. input file is like that: 2014 3 20 15 0 5.270 40.7739 27.6471 20.232 0.6 0 0 0 1 Site6 4.081 1.00 P Site6 7.585 1.00 S Site1 4.441 1.00 P... (9 Replies)
Discussion started by: miriammiriam
9 Replies

3. Shell Programming and Scripting

awk loop using array:wish to store array values from loop for use outside loop

Here's my code: awk -F '' 'NR==FNR { if (/time/ && $5>10) A=$2" "$3":"$4":"($5-01) else if (/time/ && $5<01) A=$2" "$3":"$4-01":"(59-$5) else if (/time/ && $5<=10) A=$2" "$3":"$4":0"($5-01) else if (/close/) { B=0 n1=n2; ... (2 Replies)
Discussion started by: klane
2 Replies

4. Shell Programming and Scripting

Why result is wrong here ? whether break statement is wrong ?

Hi ! all I am just trying to check range in my datafile pls tell me why its resulting wrong admin@IEEE:~/Desktop$ cat test.txt 0 28.4 5 28.4 10 28.4 15 28.5 20 28.5 25 28.6 30 28.6 35 28.7 40 28.7 45 28.7 50 28.8 55 28.8 60 28.8 65 28.1... (2 Replies)
Discussion started by: Akshay Hegde
2 Replies

5. UNIX for Dummies Questions & Answers

Loop and variable not exactly variable: what's wrong

Hello guys, This truly is a newbie question. I'm trying to make a loop to execute simultaneous commands indefinitely while using variable. Here is how my mess looks like (this is just an example): #!/bin/bash IP=`shuf -n 1 IP.txt` # I figured this would be easier to select random lines... (4 Replies)
Discussion started by: bobylapointe
4 Replies

6. Shell Programming and Scripting

what's wrong with that loop ?

hello everybody, here's my code mkf () { INDEX=0; while ; do touch "file$1.f"; INDEX=$INDEX+1; done } when I type mkf 10 the loop seems to act infinite and only the last file of the loop is created, in the example below, there just is file10.f in... (11 Replies)
Discussion started by: Oddant
11 Replies

7. Shell Programming and Scripting

Whats wrong with my Loop

Hi all, I have been given a task to search for strings in a file that is encoded. I need to display the file name only when all the 3 strings which i provide are present in the file name. i first try to get a list of files according from the directory according to the value passed in argument... (0 Replies)
Discussion started by: amit1_x
0 Replies

8. Shell Programming and Scripting

Something wrong with while loop

Hi there, i've written a script to extract a portion of a MySQL database table and convert it to CSV and then to import it back as CSV to MySQL. Initially it worked without the while loop but after adding the while loop statement, i am getting the following error: ./export-csv-coordinates.sh:... (4 Replies)
Discussion started by: edge80
4 Replies

9. Shell Programming and Scripting

Something went wrong in the following loop

The script is And the error is + count=2 ./FindEID.ksh: line 227: syntax error near unexpected token `else' ./FindEID.ksh: line 227: ` else' I just can't find out what the problem is, can anyone tell me about this error is? Thank you (5 Replies)
Discussion started by: tpltp
5 Replies

10. Shell Programming and Scripting

new to shell scripting: whats wrong with my if loop

#!/bin/bash for file in $HOME/*; do if ; then rm -i $file > /dev/null echo "$?" echo "$file has been deleted" fi done Been trying to learn shell scripting for a week or so now, when i run the script it doesnt display an error message, seems like it runs fine, however it doesnt delete... (10 Replies)
Discussion started by: stride6
10 Replies
Login or Register to Ask a Question