Shell script - if statements dont work


 
Thread Tools Search this Thread
Top Forums Programming Shell script - if statements dont work
# 1  
Old 12-06-2016
Shell script - if statements dont work

hi all,

i have made a shell script and it runs until it reaches the if statement, doesn't the ! mean only if the command fails it will echo me that message and then exit

can anyone please help me what is wrong with my code?

many thanks,

rob

Code:
#!/bin/bash

    echo "is this archive for an audio tar (press 1) or an audio directory (press 2)"
    read method

    case $method in
        1)
            echo "please specify full path to directory where the tar file is in"
            read -e dir
            cd $dir

            echo "please copy/paste filename here of tar file (including .tar)"
            read -e tar

            echo "please enter ID number ie ID1234"
            read id

            echo "please specify where you want the tar file to be stored"
            read -e dest

            if ! mv $tar $id_$tar ; then
                echo "something went wrong with the mv command, please do manually"
                exit
            fi

            if ! rsync -avh $id_$tar $dest ; then
                echo "something went wrong with the rsync command, please do manually"
                exit
            fi

            if ! rm -f $id_$tar ; then
                echo "something went wrong with the rm command, please do manually"
                exit
            fi
                
            ;;

        2)
            i have yet to do this one, but this is the directory one
            ;;


        *)
            echo "invalid selection, please re-run the script"
            exit

            ;;

    esac

# 2  
Old 12-06-2016
Hello robertkwild,

What input do you use and what errors do you get?

You might be hitting a number of problems because you have minimal error checking and your mv command might have a null input so becomes invalid too. This might not be a problem for a simple helper script for yourself but might be more confusing if you delegate it.

Is a null response to the source directory okay? That would change to the user's home directory.



Robin
# 3  
Old 12-06-2016
this is the result on what the end user sees -

https://s17.postimg.org/a71wi9xxr/script.png

and after the end user presses the enter key when they tab the stored directory, it suddenly quits the script
# 4  
Old 12-06-2016
I regret I cannot open that link - office internet access restriction. Can you post the content as text in CODE tags?



Robin
# 5  
Old 12-06-2016
Code:
is this archive for an audio tar (press 1) or an audio directory (press 2)
1
please specify full path to directory where the tar file is in
/to_be_archived/
please copy/paste filename here of tar file (including .tar)
untitled\ folder.tar 
please enter ID number ie ID1234
ID1234
please specify where you want the tar file to be stored
/archived_projects/

the above to get the directory or tar file all i need to do is tab as i have the e option which means interact with shell
# 6  
Old 12-06-2016
Thank you for this. Can you run it again with bash -x your_script and paste the output. It will look messy, but it will show what your code is actually trying to do and what conditions are met in the if statements.



Thanks again,
Robin
# 7  
Old 12-06-2016
not wrong there when you said it looks ugly!!!

Code:
[root@robw-linux /]# bash -x test.sh
+ echo 'is this archive for an audio tar (press 1) or an audio directory (press 2)'
is this archive for an audio tar (press 1) or an audio directory (press 2)
+ read method
1
+ case $method in
+ echo 'please specify full path to directory where the tar file is in'
please specify full path to directory where the tar file is in
+ read -e dir
/to_be_archived/
+ cd /to_be_archived/
+ echo 'please copy/paste filename here of tar file (including .tar)'
please copy/paste filename here of tar file (including .tar)
+ read -e tar
untitled\ folder.tar 
+ echo 'please enter ID number ie ID1234'
please enter ID number ie ID1234
+ read id
ID1234
+ echo 'please specify where you want the tar file to be stored'
please specify where you want the tar file to be stored
+ read -e dest
/archived_projects/
+ mv untitled folder.tar untitled folder.tar
mv: target `folder.tar' is not a directory
+ echo 'something went wrong with the mv command, please do manually'
something went wrong with the mv command, please do manually
+ exit
[root@robw-linux /]#

---------- Post updated at 09:10 AM ---------- Previous update was at 09:07 AM ----------

mmm... its not appending the ID number to it ie ID1234_untitled folder.tar
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Dont want to mention user id passwd in shell script

Hi, i have one shell script which transfers files from one server to other server through FTP, but i can see login id and password is not mentioned. kindly help to understand the script.then how below script is working if login and password is not mentioned in script #!/bin/sh... (1 Reply)
Discussion started by: ni3b007
1 Replies

2. Programming

Breakpoints dont work in Codeblocks, code does not build

Hey so I've written a program and it crashes every time I run it. I tried placing breakpoints to see what was going but to my surprise they do not work! I've placed them anywhere and they do not stop the execution of the program. In fact if I add code and hit rebuild it doesn't even build that... (1 Reply)
Discussion started by: Cambria
1 Replies

3. Shell Programming and Scripting

Can we use two shebang statements in a single shell script?

Hi, As per my understanding, we can use two shebang statements in a single shell script. Please see below snippet- #!/bin/bash .......## some code A #!/bin/csh .......## some code B exit 0; Here, code A will be executed using bash shell and code B will be executed with c shell. ... (9 Replies)
Discussion started by: tarunmudgal4u
9 Replies

4. UNIX for Dummies Questions & Answers

keyboard and mouse dont work after sometime from boot in linux.

when i started booting linux ,after sometime both the mouse and the keyboard are getting freeze and wont respond(also the system gets hanged and all the process running dont go forward) ,nothing seem to work. Keeping in mind that it will work after sometime ,i waited for one hour also ,but... (1 Reply)
Discussion started by: sanjay.login
1 Replies

5. Shell Programming and Scripting

Substitution in a file dont work with an Array in filename

Hi. I´ve a script that should substitude the 8th line in a file called xxx.num6. The "xxx" is set by an array filled with this command: j=0 for Par in *.sys ; do Par=`echo $Par | sed 's/\(.*\).sys/\1/'` ; Par2="$Par" ; echo "${Par2}" j=$((j + 1)); done Now i try... (0 Replies)
Discussion started by: Lock3
0 Replies

6. Shell Programming and Scripting

Looping through a shell script with sql statements

Hello members, I'm working on the Solaris environment and the DB i'm using is Oracle 10g. Skeleton of what I'm attempting; Write a ksh script to perform the following. I have no idea how to include my sql query within a shell script and loop through the statements. Have therefore given a... (4 Replies)
Discussion started by: novice82
4 Replies

7. Shell Programming and Scripting

if [ -z echo foo | egrep -e 'regexp' != '' ] -> dont work

Hallo, I need to test a String (a special ip number-string). So I want to run that: ipadress=172.0.0.0 # for debugging: echo $ipadress | egrep -e '172\.?\.??\.??$' # the test that doesnt work if test -z `echo $ipadress | egrep -e '172\.?\.??\.??$'` != "" then echo "match" else... (1 Reply)
Discussion started by: wiseguy
1 Replies

8. UNIX for Advanced & Expert Users

why the date format dont work in crontab

Hi I tried to put a cron job which pipes the logfile appended to date +%d but it didnt work . anyone know how to make this happen thanks in advance -prasad (7 Replies)
Discussion started by: p4cldba
7 Replies

9. Shell Programming and Scripting

Running remote shell script containing sql statements

I have a shell script which resides on three SCO machines containing some simple sqlplus statments. I need to run these scripts remotely. Currently, I am trying to use rsh to do so: rsh hostname myscript args The problem is that the arguments to the sqlplus statements in the remote shell... (4 Replies)
Discussion started by: Madbreaks
4 Replies

10. Filesystems, Disks and Memory

OS X / fsck / apps dont work no control panel

Alright. My neighbor kid brings me his iBook and says nothing works. He decided to move the file system to his likeness and that semed to create the problems. Now he doesn't have access rights to his home. I have run fsck over and over again and I keep getting ** fs modified ** I have also... (0 Replies)
Discussion started by: maxwell
0 Replies
Login or Register to Ask a Question