Nanosleep in signal call


 
Thread Tools Search this Thread
Top Forums Programming Nanosleep in signal call
# 1  
Old 12-30-2015
Nanosleep in signal call

Hi @ll Smilie

I have a problem with my code but first a short description:

1. I have one signal call SIGUSR1
2. In the signal I try to use nanosleep and now:

When I put kill -SIGUSR1 pid --> sometimes works fine, sometimes returns me an error with ,,Interrupt system call", sometimes I got error with "Success". Why? What mistake did I make? How to improve that?

My code:

Code:
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <errno.h>
#include <signal.h>
#include <time.h>

void handler_signal(int signal)
{
   const char *signal_name;
   sigset_t pending; // syngaly oczekujace
   int losowy_czas ;  
   struct timespec ts; 
   int ret; 
   
   
   losowy_czas = rand() % 15 + 5;  
   ts.tv_sec = 0; 
   ts.tv_nsec = losowy_czas * 100000000;
   
   ret = clock_nanosleep(CLOCK_MONOTONIC,0,&ts,NULL); 

   if(ret)
	perror("Blad funkcji clock_nanosleep");   	


   switch(signal)
   {
   	case SIGUSR1:
		signal_name = "SIGUSR1"; 
		break;
	default:
		fprintf(stderr,"Zlapany zly sygnal: %d \n", signal); 
		return; 
  }

  //unsafe I know ! 
  printf("To ja - sygnal ! %s Wylosowany czas %d \n", signal_name,losowy_czas);  

}
int main(int argc, char *argv[])
{
   int i; 
   char *endptr; 
 
   struct sigaction sa; 	
 
  
   srand((unsigned int) time(NULL)); 
   /*     PROCES P    */


   sa.sa_handler = &handler_signal;
   sa.sa_flags = SA_RESTART; 
   
   sigfillset(&sa.sa_mask); 
   
   if(sigaction(SIGUSR1,&sa,NULL) == -1)
   {
	perror("Nie mozna obsluzyc SIGUSR1");	
   }

   
   for(i=0; i<2000; i++)
   {
     printf("Running %i \n", i);
     sleep(1); 
   }  

   return;
}


Last edited by Scrutinizer; 12-30-2015 at 02:33 PM.. Reason: Spelling
# 2  
Old 12-30-2015
I believe rand() is not async safe as well - you cannot have interruptible calls in your signal handler. Well make that should not have. It uses global variables which is another problem. Plus you are doing a lot in your signal handler, so also consider blocking SIGUSR1 as the first step in your handler. Multiple signals can mess up your code otherwise - especially the rand() call. New applications should use the POSIX signal API (sigaction(2), sigprocmask(2), etc.) which is what you did and that is good.

Next:
Code:
signal_name = "SIGUSR1";

could SEGFAULT, but in any case it is undefined behavior: const *signal_name;

Last edited by jim mcnamara; 12-30-2015 at 07:39 PM..
# 3  
Old 12-31-2015
THX for ansewer, mate !

Ok, so: I have to have some random numbers - Can I do that better? (1)
Second - I try to block SIGUSR1 -I will be grateful if you could tell if I do this in the right way.
Code:
void handler_signal(int signal)
{
   sigset_t pending; // syngaly oczekujace
   int losowy_czas ;  
   struct timespec ts; 
   int ret; 
   sigset_t mask; 
  
   sigemptyset (&mask);
   sigaddset (&mask, SIGUSR1); // block SIGUSR1
   
   srand((unsigned int) time(NULL));    //transfer RAND here
   losowy_czas = rand() % 15 + 5;  
   ts.tv_sec = 0; 
   ts.tv_nsec = losowy_czas * 100000000;
   
   ret = clock_nanosleep(CLOCK_MONOTONIC,0,&ts,NULL); 

   if(ret)
	perror("Blad funkcji clock_nanosleep");   	


   switch(signal)
   {
   	case SIGUSR1: 
		break;
	default:
		fprintf(stderr,"Zlapany zly sygnal: %d \n", signal); 
		return; 
  }

  //unsafe
  printf("To ja - sygnal !  Wylosowany czas %d \n", losowy_czas);  

}


In the singal will be some read function but first I want to have sure that everything is all right.
# 4  
Old 12-31-2015
I am guessing you do not want signal handling at all, other than cleaning up open files and buffers when your app gets a SIGTERM, for example.

Why? read.

This says you are designing an app that has an associated process that is doing reads.
Consider another standard IPC model instead. They are a much better choice if you must do reads in one process.

Overview:
http://www.tldp.org/LDP/tlk/ipc/ipc.html

Pipes are great, they are very like playing with files.
The GNU C Library: Creating a Pipe


Shared memory among processes is also a great feature. You can atomically set a variable in shared memory, then execute a read into a buffer there.
Use semaphores for traffic control. This one is straightforward to get right.
shm_overview(7) - Linux manual page

Overall, consider getting a copy of 3rd Edition of Stevens & Rago 'Advanced Programming in the UNIX Environment'. Michael Kerrisk has done the same thing purely for Linux - 'The LINUX Programming Interface'

Both of these have great examples of all of IPC, and explain how not to shoot yourself in the foot. Like you seemed to want to do. They fully cover signals as well, if you cannot change your system design, and have to continue into the Dark Side.

Have a good New Year!

Last edited by jim mcnamara; 12-31-2015 at 11:11 AM..
# 5  
Old 12-31-2015
Thank you very much ! However I have to do this part of work with signals.. next chapter will be pipe... Anyhow I will trying to clean code just a little bit, remove printf - unsafe method, write code associated with read and we will see.

Thx one more time and Happy 2016 mate ! Smilie
# 6  
Old 01-17-2016
Its always best to keep it simple.
Most texts you read on signals recommend getting out of the handler ASAP.
A simple way it just use the handler to set a flag.

Code:
static int signal;

void call_cleanup(int sig)
{
     signal = sig;
}

int sigs[] = { 1, 2, 3, 15, 0 };
set_signal_handler(sigs, call_cleanup);

for (;;) {
      
    if (signal) break;

    blah(this)
    blah(that);

}

// cleanup code here

Login or Register to Ask a Question

Previous Thread | Next Thread

9 More Discussions You Might Find Interesting

1. Programming

nanosleep

Application runs on both solaris 6 and 10. solaris 6 having only posix4.so library, solaris 10 having libposix4.so and librt.so Can we link application to lposix4 instead of lrt for nanosleep, sothat application will run in both machines? (2 Replies)
Discussion started by: satish@123
2 Replies

2. Programming

Where is nanosleep?

I use nanosleep under solaris10,like follows: #include <pthread.h> #include <time.h> #include <sys/time.h> struct to_info{ void (*to_fn)(void *); void *to_arg; struct timespec to_wait; }; void *timeout_helper(void *arg){ struct to_info *tip; nanosleep(&tip->to_wait,NULL);... (1 Reply)
Discussion started by: konvalo
1 Replies

3. UNIX for Dummies Questions & Answers

Why do I need to call make if I call gcc ?

Why do I need to call make if I call gcc ? I thought gcc already compiles the sources. thanks (1 Reply)
Discussion started by: aneuryzma
1 Replies

4. Infrastructure Monitoring

diffrence between method call and function call in perl

Hello, I have a problem with package and name space. require "/Mehran/DSGateEngineLib/general.pl"; use strict; sub System_Status_Main_Service_Status_Intrusion_Prevention { my %idpstatus; my @result; &General_ReadHash("/var/dsg/idp/settings",\%idpstatus); #print... (4 Replies)
Discussion started by: Zaxon
4 Replies

5. Programming

Problem with signal handler and interrupted system call

Hi, I have a daq program that runs in an infinite loop until it receives SIGINT. A handler catches the signal and sets a flag to stop the while loop. After the loop some things have to be cleaned up. The problem is that I want my main while loop to wait until the next full second begins, to... (2 Replies)
Discussion started by: soeckel
2 Replies

6. Programming

nanosleep returns prematurely, with return value 0

Hi, I have encountered the following problem on Solaris 10: I have a thread that is asleep on nanosleep (set to 24 hours). Something that happens on another thread, causes the nanosleep to exit, even though the time has not elapsed. The returned value is 0 (so it doesn't look like it... (1 Reply)
Discussion started by: MeMyself
1 Replies

7. UNIX for Advanced & Expert Users

how to differentiate system call from library call

Hi, Ho do I differentiate system call from library call? for example if I am using chmod , how do I find out if it is a system call or library call? Thanks Muru (2 Replies)
Discussion started by: muru
2 Replies

8. Programming

nanosleep

Hello, Can anyone, please, guide me on the use of nanosleep. I'm learning threads. I want to introduce a delay (not nested for loops, something more customizable). Nanosleep looked useful (or any other form of customizable and easy-to-use delay). Sleep is too long. :) (2 Replies)
Discussion started by: ameya
2 Replies

9. Programming

sigwait system call in UNIX signal

Hi Everybody, I have gone through man of sigwait and new to UNIX signals. Could anyone explain me about the following lines mentioned in sigwait man help ? "The selection of a signal in set is independent of the signal mask of the calling thread or LWP. This means a thread or LWP can ... (1 Reply)
Discussion started by: md7ahuja
1 Replies
Login or Register to Ask a Question