How to trim the white space around a string in C program


 
Thread Tools Search this Thread
Top Forums Programming How to trim the white space around a string in C program
# 8  
Old 10-09-2008
...then at that point it is up to the programmer to determine if 'frequently' warrants the register class or not.

If you don't like the register class, fine, don't use it, in an instance such as this.

I felt that it might very well improve the performance of the function, hence the inclusion.
# 9  
Old 10-09-2008
register variables aren't that free when compared to auto variables and they should be only be sparsely used when that is really needed. I felt for the above code is not needed. Anyway its up to the programmer to decide and the compiler is not going to complain about this.

Its going to allocate if that can find one, else its going to be an auto variable anyway

Smilie
# 10  
Old 10-09-2008
This is optimizing in the wrong place. Your algorithm is O(nē), with or without register. Trimming a string can be done in O(n), which is much more efficient. On the other hand the function has not that much variables, so the compiler will most probobly use reigisters for all of them anyway (if the strlen() call doesn't make that impossible)
# 11  
Old 10-09-2008
You could also use POSIX's regular expressions (regcomp(), regexec(), regfree()).

First you compile a regex using regcomp(), then you can match it several times to a certain string using regexec(). Finally you should free the compiled regex with regfree().

A very simple example:
Code:
#include <stdio.h>
#include <regex.h>

int
main ()
{
    regex_t reg;
    char * aaa = "          ";
    
    if (regcomp (&reg, "[^[:space:]$]", REG_EXTENDED|REG_NOSUB) != 0)
        exit(1);
    if ((regexec (&reg, aaa, 0, (regmatch_t *) NULL, 0)) == 0)
         printf ("no match\n");
    else
        printf ("match\n");
    regfree(&reg);
}

# 12  
Old 10-09-2008
This is all just overkill. There are three variants to do trimming in C:

1. Output in another place
Code:
void trim_copy(char *input, char *output)
{
  char *end = ouput;
  char c;

  // skip spaces at start
  while(*input && isspace(*input))
    ++input;

  // copy the rest while remembering the last non-whitespace
  while(*input)
  {
    // copy character
    c = *(output++) = *(input++);

    // if its not a whitespace, this *could* be the last character
    if( !isspace(c) )
      end = output;
  }

  // white the terminating zero after last non-whitespace
  *end = 0;
}

2. In place
Code:
void trim_inplace(char *s)
{
  trim_copy(s, s);
 }

3. In place, but avoid copying by shifting string pointer
Code:
char *trim_nocopy(char *s)
{
  char *start = s;

   // skip spaces at start
  while(*start && isspace(*start))
    ++start;

  char *i = start
  // iterate over the rest remebering last non-whitespace
  while(*i)
  {
    if( !isspace(*(i++)) )
      end = i;
  }

  // white the terminating zero after last non-whitespace
  *end = 0;

  return start;
}

All three solutions are O(n). Use in place if you don't need the original anymore (and it's not constant like a literal). If you use new or malloc to allocate memory, then delete/free the original pointer in case 3, not the returning value.
# 13  
Old 10-10-2008
Quote:
Originally Posted by redoubtable
You could also use POSIX's regular expressions (regcomp(), regexec(), regfree()).

First you compile a regex using regcomp(), then you can match it several times to a certain string using regexec(). Finally you should free the compiled regex with regfree().

A very simple example:
Code:
#include <stdio.h>
#include <regex.h>

int
main ()
{
    regex_t reg;
    char * aaa = "          ";
    
    if (regcomp (&reg, "[^[:space:]$]", REG_EXTENDED|REG_NOSUB) != 0)
        exit(1);
    if ((regexec (&reg, aaa, 0, (regmatch_t *) NULL, 0)) == 0)
         printf ("no match\n");
    else
        printf ("match\n");
    regfree(&reg);
}

This code doesn't compile (regcomp throws an error)... is there any way to get regcomp/regexec to recognize whitespace (using "_" doesn't work) or a word boundary?
# 14  
Old 10-10-2008
Quote:
Originally Posted by monikersupreme
This code doesn't compile (regcomp throws an error)... is there any way to get regcomp/regexec to recognize whitespace (using "_" doesn't work) or a word boundary?
The code compiles under gcc 4.1.2 Linux. As to the other question, yes it's possible. Try searching google for "POSIX.2 regular expressions" for more information.
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Trim Space

In Shell, I have output of a unix command as test1 test2015 but I want it as test1 test2015 can anyone help me out. Use code tags, thanks. (3 Replies)
Discussion started by: OscarS
3 Replies

2. Shell Programming and Scripting

Putting white Space at the end of the string

Hi Guys, Hope, you all are doing good out there. I am writing a shell script and currrint in need of your help. This is what I need to do; I have position based plain file. One of the fields is 15 character long. I need to fill that field. The problem is that the value is dynamic, it could... (4 Replies)
Discussion started by: singh.chandan18
4 Replies

3. Shell Programming and Scripting

Add white space

hi guys how can i add spacein file name with sed if strings have no space around dash input 19-20 ( 18-19 ) ABC-EFG output after add white space 19 - 20 (18 - 19 ) ABC - EFG thx in advance (2 Replies)
Discussion started by: mhs
2 Replies

4. Shell Programming and Scripting

awk - trim white space from a field / variable

Hi, Consider the data (FS = |): 1| England |end 2| New Zealand |end 3|Australia|end 4| Some Made Up Country |end 5| West Indies|end I want the output to be (i.e. without the leading and trailing white space from $2) England New Zealand Australia Some Made Up Country West... (4 Replies)
Discussion started by: Storms
4 Replies

5. UNIX for Dummies Questions & Answers

filename with white space

our user creates a text file with a white space on the filename. this same file is transfered to unix via automation tool. i have a korn shell script that reads these files on a input directory and connects to oracle database to run the oracle procedures which will load the data from each of the... (2 Replies)
Discussion started by: wtolentino
2 Replies

6. Shell Programming and Scripting

sed + white space

Hi, What sed command (if sed is the right command) can remove ALL white space from my file. I have a csv, except I want to remove all white space between commas and characters. My idea (without testing) sed 's/ //g' Is there a better way? (18 Replies)
Discussion started by: mcclunyboy
18 Replies

7. UNIX for Dummies Questions & Answers

SED with White Space

Dear Members, Suppose i have a variable test which stores a string as below: test='John drives+++++++++a+++++car' now i want to use sed on the above variable and replace + with a white space, so that i get echo $test should give me 'john drives a car' Between... (1 Reply)
Discussion started by: sandeep_1105
1 Replies

8. Shell Programming and Scripting

stripping white space...

Hi All; Having a problem with a file.. the file contains the following data... (a snapshot) 1331F9E9DB7C2BB80EAEDE3A8F043B94,AL7 1DZ,M,50 186FDF93E1303DBA217279EC3671EA91,NG5 1JU,M,24 3783FFAF602015056A8CD21104B1AAAF,CH42 4NQ,M,17 It has 3 columns sepreated by a , the second column... (7 Replies)
Discussion started by: Zak
7 Replies

9. Shell Programming and Scripting

Trim white spaces using awk

Hi, I have a CSV file with footer information as below. The third value is the number of records in the file. Sometimes it contains both leading and trailing white spaces which i want to trim using awk. C,FOOTER , 00000642 C,FOOTER , 00000707 C, FOOTER,... (2 Replies)
Discussion started by: mona
2 Replies

10. Shell Programming and Scripting

How to trim space in output variable ?

Hi , I have a code like this: uid=scott password=tiger database=db01 cat >runid_val.sql<<-EOA SET ECHO OFF SET FEEDBACK OFF SET HEADING OFF SELECT trim(runid_seq.nextval) FROM dual; EXIT EOA echo `cat runid_val.sql` V_RUNID=`sqlplus -s $uid/$password@$database @runid_val.sql`... (5 Replies)
Discussion started by: vj_76
5 Replies
Login or Register to Ask a Question