Need help with Card Dealing Program


 
Thread Tools Search this Thread
Top Forums Programming Need help with Card Dealing Program
# 1  
Old 03-28-2011
Need help with Card Dealing Program

I'm currently making a card dealing program, it is suppose to display a list of cards like this:
"Ace of Heart, is red"
"Two of Heart, is red"
.
.
"Ace of Spade, is black"
and so on for all suits and numbers.

here is my current code:
Code:
#include <stdio.h>
#include <stdlib.h>
#include <time.h>

struct card { 
 const char *face;
 const char *suit;
 const char *color;
};

typedef struct card Card;
typedef unsigned char pairs;

const char *face[] = { "Ace", "Two", "Three", "Four", "Five","Six", "Seven",
                                  "Eight", "Nine", "Ten","Jack", "Queen", "King"};
const char *suit[] = { "Hearts", "Diamonds", "Clubs", "Spades"};
const char *color[]= {"Black","Red"};
void printdeck( const Card * const );
void fillDeck( Card * const, const char *[], const char *[] ,const char *[]);
void deal(card cards[52], card hands[5][5]);
int main()
{
int hand,cd,winner;
card hands[5][5],handssorted[5][5];
pairs numpairs[5],highest;
Card deck[52];
srand( time( NULL) );
fillDeck( deck, face, suit, color );
printdeck(deck);
printf("\n ----------------------------------------------------------\n");

system("pause");
return 0;

}
//------------------------------------------------------------------------------------------------------
void fillDeck( Card * const wDeck, const char * wFace[], const char * wSuit[], const char * wColor[])
{
		   int i;
		   for ( i = 0; i <= 51; i++ ) { 
		      wDeck[i].face  = wFace[ i % 13 ];
		      wDeck[i].suit  = wSuit[ i / 13 ];
		      wDeck[i].color = wColor[i%2];
        }
}
//-----------------------------------------------------------------------------------------------------
void shuffle( Card * const wDeck )
{
		   int i, j;
		   Card temp;
		   for ( i = 0; i <= 51; i++ ) { 
		      j = rand() % 52;
		      temp = wDeck[ i ];
		      wDeck[ i ] = wDeck[ j ];
		      wDeck[ j ] = temp;
}
}
//-----------------------------------------------------------------------------------------------------------
void printdeck( const Card * const wDeck )
{
           int i;
		   for ( i = 0; i <= 51; i++ ){
		      printf( "\t%s\t of \t%-8s is \t%s \n \t", wDeck[i].face, 
		              wDeck[i].suit,wDeck[i].color,
		             ( i + 1 ) % 2 ? '\t' : '\n' );}
}

but the output i get it wrong because it shows:
"Ace of Hearts is Black"
"Two of Hearts is Red"
"Three of Hearts is Black"
.
.
the color displayed is wrong. Im not sure what im doing wrong, can anyone pls help.
# 2  
Old 03-28-2011
Quote:
Originally Posted by Izzy123
const char *suit[] = { "Hearts", "Diamonds", "Clubs", "Spades"};
const char *color[]= {"Black","Red"};

wDeck[i].face = wFace[ i % 13 ];
wDeck[i].suit = wSuit[ i / 13 ];
wDeck[i].color = wColor[i%2];
I'm not much of a cardshark, but if all hearts/diamonds are supposed to be red and all clubs/spades are intended to be black, you could switch the order of the colors in the color array and use wColor[i/26] to get the job done. However, even though that's the shortest path to accomplishing the task (using your current code as a starting point), it's not a good solution; it creates a dependency between disparate lines of code that is not apparent and would require some documentation to highlight the hazard.

It would be better to use a different approach which makes clear the relationship between suit and color.

Regards,
Alister
# 3  
Old 03-28-2011
In filldeck, you assign the color by
Code:
wDeck[i].color = color[i % 2];

This means, that it will always alternate between black - red - black - red - etc... after every card! I am not sure which color diamaonds have (arent they blue?), so a very simple approach would be (where I assume all but hearts is black):

Code:
wDeck[i].color = (wDeck[i].suit == wSuit[0]) ? "Red" : "Black";

# 4  
Old 03-28-2011
Why not have each card as a unique number, and decide from that number what suit it is? The suit defines the color, so that solves both problems.

Code:
#include <stdio.h>

enum suit_t
{
        // Arranged in this order to get black/red/black/red.
        SUIT_CLUB=0,    // 0 & 1 == 0.  Black.
        SUIT_HEART=1,   // 1 & 1 == 1.  Red.
        SUIT_SPADE=2,   // 2 & 1 == 0.  Black.
        SUIT_DIAMOND=3  // 3 & 1 == 1.  Red.
};

enum card_t
{
        CARD_MIN=0, CARD_MAX=52,

        // Cards are numbered as 0, 4, 8, 12, etc.  The first 2 bits decide the suit.
        CARD_ACE=(0<<2),      CARD_2=(1<<2),
        CARD_3=(2<<2),          CARD_4=(3<<2),
        CARD_5=(4<<2),          CARD_6=(5<<2),
        CARD_7=(6<<2),          CARD_8=(7<<2),
        CARD_9=(8<<2),          CARD_10=(9<<2),
        CARD_JACK=(10<<2),      CARD_QUEEN=(11<<2),
        CARD_KING=(12<<2)
};

const char const *cardnames[]={
        "Ace", "Two", "Three", "Four", "Five", "Six", "Seven",
        "Eight", "Nine", "Ten", "Jack", "Queen", "King", NULL };

const char const *colornames[]={ "Black", "Red", NULL };
const char const *suitnames[]={"Clubs", "Hearts", "Spades", "Diamonds", NULL };

#define CARD_NAMESTR(X)         (cardnames[(X)>>2])
#define CARD_SUITSTR(X)         (suitnames[(X)&SUIT_DIAMOND])
#define CARD_COLORSTR(X)        (colornames[((X)&1)])

int main(void)
{
        int card;

        for(card=CARD_MIN; card < CARD_MAX; card++)
        {
                printf("card %d is the %s of %s, and is %s\n", card,
                        CARD_NAMESTR(card), CARD_SUITSTR(card),
                        CARD_COLORSTR(card));
        }
}

Code:
card 0 is the Ace of Clubs, and is Black
card 1 is the Ace of Hearts, and is Red
card 2 is the Ace of Spades, and is Black
card 3 is the Ace of Diamonds, and is Red
card 4 is the Two of Clubs, and is Black
card 5 is the Two of Hearts, and is Red
card 6 is the Two of Spades, and is Black
card 7 is the Two of Diamonds, and is Red
...
card 44 is the Queen of Clubs, and is Black
card 45 is the Queen of Hearts, and is Red
card 46 is the Queen of Spades, and is Black
card 47 is the Queen of Diamonds, and is Red
card 48 is the King of Clubs, and is Black
card 49 is the King of Hearts, and is Red
card 50 is the King of Spades, and is Black
card 51 is the King of Diamonds, and is Red


Last edited by Corona688; 03-28-2011 at 03:36 PM..
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Programming

Dealing with XML comments

I'm writing my own simple XML parser as an experiment. It's a lot more complicated than it's supposed to be. Things supposedly forbidden in XML comments happen all the time in the wild. You're never, ever supposed to find -- inside <!-- xml comments --> but in practice, you don't just find... (2 Replies)
Discussion started by: Corona688
2 Replies

2. Shell Programming and Scripting

Dealing with edge-list

I have an edge-list with nodes, edge.txt A B B J J H C A G H G A A C K G I have another file which tells me which of these nodes are important, input.txt G C A (3 Replies)
Discussion started by: Sanchari
3 Replies

3. UNIX for Dummies Questions & Answers

Dealing with sum

I have file input 1/1/2013 1AS030A 0 1083 CHINA 1/1/2013 1AS030B 0 675 KOREA 1/1/2013 1AS035A 162 662 CHINA 1/1/2013 1AS035B 51 799 INDIA 1/1/2013 1AS035C 0 731 CHINA 1/2/2013 1AS073A 10 1375 KOREA... (5 Replies)
Discussion started by: radius
5 Replies

4. Shell Programming and Scripting

Dealing with multiple files

Korn Shell I have hundreds of small files like below created every day. A midnight cron job moves them to the location /u04/temp/logs But sometimes I have to manually move these files based a certain dates or time. I have two basic requirements 1.Using mv command I want to move all .dat... (2 Replies)
Discussion started by: kraljic
2 Replies

5. UNIX and Linux Applications

Dealing with geany core

Geany : Home Page, the text editor, sometimes crashes and leaves a geany.core file. This is a binary file and supposedly contains all unsaved work and possibly some other information. Does anyone know how to deal with this file? (2 Replies)
Discussion started by: figaro
2 Replies

6. Shell Programming and Scripting

cp not dealing with variable properly? please help

I am having trouble with a script that is supposed to : a)take all the jpg pictures in a given directory/parameter and create thumbnails of it in a directory on the desktop. e.g from /here/are/the/files.jpg to ~/Desktop/parser-the/files.png this is my script: all the individual parts... (2 Replies)
Discussion started by: orochinagi
2 Replies

7. Shell Programming and Scripting

Dealing with files with spaces in the name

Hello, I'm a computer science major and I'm having problems dealing with file names with spaces in them. Particularly I'm saving a file name in a variable and then using the variable in a compare function i.e. a='te xt.txt' b='file2.txt' cmp $a $b If anyone could help me with this particular... (10 Replies)
Discussion started by: jakethegreycat
10 Replies

8. UNIX and Linux Applications

webinject - dealing with popups

Hello We have a webapp that launches a link in a popup. We need to use webinject to check the content of that popup but have been so far unsuccessful. We use webinject as a nagios plugin. Does anyone have any experience of using/configuring webinject and know if this is possible or not? ... (1 Reply)
Discussion started by: skewbie
1 Replies

9. UNIX Desktop Questions & Answers

Does Red Hat Fedora support Nvidia card 8800GTX and 260 card?

Does Red Hat Fedora support Nvidia card 8800GTX and 260 card? Does any Linux OS support Nvidia card? (1 Reply)
Discussion started by: sito
1 Replies

10. Shell Programming and Scripting

Help in dealing with arra

I am readinga file lin by line and based craeting a arry of unique elemenst from the second column of the line. However when i coem out of the while loop my array becomes empty , can eny one tell me what I would be doing wrong #!/bin/bash logfile="./mylog.dat" begin=100 end="$(( $begin +... (5 Replies)
Discussion started by: jojan
5 Replies
Login or Register to Ask a Question