if/elif help

 
Thread Tools Search this Thread
Homework and Emergencies Homework & Coursework Questions if/elif help
# 1  
Old 06-27-2011
if/elif help

Use and complete the template provided. The entire template must be completed. If you don't, your post may be deleted!

1. The problem statement, all variables and given/known data:
This is my problem for the class.

Write a script that asks for the user's age. If it is equal to or higher than 16, print a message saying that
this user is allowed to drink alcohol. If the user's age is below 16, print a message telling the user how
many years he or she has to wait before legally being allowed to drink.
As an extra, calculate how much beer an 18+ user has drunk statistically (100 liters/year) and print
this information for the user.

I can make it do the if older than 16 then you can drink
Also If you are 15 or younger than you have to wait X years until you can drink

My problem id with the calculation of how many liters you have drank since 18+.


2. Relevant commands, code, scripts, algorithms:
if/elif commands


3. The attempts at a solution (include all code and scripts):
Code:
#!/bin/bash

year=100

echo "Hello, "$USER".  This script will see if your old enough for a beer."

echo -n "Enter your age and press [ENTER]: "
read age

if  [ $age -gt 15 ]; then
  echo "You are ready for a beer!" 
  myvar2=$(expr $age + $year ) < --This is the problem
  echo "You have drank $year liters/year since you were 18 year old."
  exit 1
elif [ $age -lt 16 ]; then
  myvar=$(expr 16 - $age)
  echo "You still have to wait $myvar more years to drink sorry."
  exit 1
  
fi


4. Complete Name of School (University), City (State), Country, Name of Professor, and Course Number (Link to Course):
Oklahoma State Institute of Technology
Okmulgee, Oklahoma
USA
Professor Fil Guinn
ITD 2313-SCRIPT PROGRAMMING-SEC LECNT1

Note: Without school/professor/course information, you will be banned if you post here! You must complete the entire template (not just parts of it).

Last edited by pludi; 06-27-2011 at 07:10 AM..
# 2  
Old 06-27-2011
Code:
myvar2=$(( $age + $year ))

... but if you don't use $myvar2 anywhere else in your script, then calculating it is useless .

Last edited by ctsgnb; 06-27-2011 at 06:58 AM..
# 3  
Old 06-27-2011
Quote:
Originally Posted by ctsgnb
Code:
myvar2=$(( $age + $year ))

... but if you don't use $myvar2 anywhere else in your script, then calculating it is useless .
$ inside a (( )) block is redundant. So are mathematical assignments outside it.

Code:
((myvar2=age+year))

# 4  
Old 06-28-2011
Quote:
Originally Posted by Corona688
$ inside a (( )) block is redundant. So are mathematical assignments outside it.

Code:
((myvar2=age+year))

most times your are right.but some older version of sh(like ash , that is usually not Posix compliant on many systems) your syntax is invalid.
[[ *maybe it is various of evulation expression bug of a ash.]]
(so its meant some older versions of (bourne) sh(s) like (0.38) has it, and i cannot test newer version ash(0.4 or newer if there is) so ash is not compability to SUSv3.

actually aritmetic expansion is defined for SUSv3
`Arithmetic Precision and Operations`
in Introduction
`2.6.4 Arithmetic Expansion`
in Shell Command Language]

now lets look at the belows..
[not expanded values before aritmetic expression]
Code:
# a=2;b=1;echo $((a+b))  
arith: syntax error: "a+b"

it is required a `$` before variables
Code:
# a=2;b=1;echo $(($a+$b))  
3


in sh another interesting issue
Code:
# unset x
# x=1

--try 1
Code:
# echo $(( $x=5 ))  
arith: syntax error: " 1=5 "

--try 2
Code:
# echo $(( $x=5 ))   
arith: syntax error: " 1=5 "

--try 3 is like OK , but?
Code:
# echo $(( $x=5 ))
5

but is not.
Code:
# echo $x
1

regards
ygemici
# 5  
Old 06-29-2011
Quote:
Originally Posted by ygemici
Code:
# echo $(( $x=5 ))  
arith: syntax error: " 1=5 "

--try 2
Code:
# echo $(( $x=5 ))   
arith: syntax error: " 1=5 "

--try 3 is like OK , but?
Code:
# echo $(( $x=5 ))
5

but is not.
Code:
# echo $x
1

regards
ygemici
Try removing the $ from the x. It evaluates into 1=5, which naturally doesn't work.
# 6  
Old 07-05-2011
You guys are conflating two different POSIX shell mechanisms here. One is the arithmetic expansion and the other is command expansion. These are different.

$(()) denotes arithmetic expansion, and $() denotes command expansion.

Shells that support $() or $(()) generally support both. For older shells that do not support these syntaxes, you need to use backticks (`) for command expansion and arithmetic expansion isn't supported. In arithmetic expansion, Corona rightly reports that you do not need $ to expand variables; however, you do need this in command expansion. For example:
Code:
$ x=1
$ y=2
$ echo $((x+y))
3

However:
Code:
$ echo $(x+y)
x+y: command not found

OTOH, if we give it an expr command:
Code:
$ echo $(expr x + y)
expr: non-numeric argument



We need explicit variable expansion:
Code:
$ echo $(expr $x + $y)

BTW, if we want compatibility with older shells that do not support arithmetic expansion, we generally are not going to be able to use new-style command expansion, so we want something like this, instead:

Code:
$ echo `expr $x + $y`
3

# 7  
Old 07-05-2011
Quote:
Originally Posted by Morgan Greywolf
You guys are conflating two different POSIX shell mechanisms here. One is the arithmetic expansion and the other is command expansion. These are different.

$(()) denotes arithmetic expansion, and $() denotes command expansion.

Shells that support $() or $(()) generally support both. For older shells that do not support these syntaxes, you need to use backticks (`) for command expansion and arithmetic expansion isn't supported. In arithmetic expansion, Corona rightly reports that you do not need $ to expand variables; however, you do need this in command expansion. For example:
Code:
$ x=1
$ y=2
$ echo $((x+y))
3

However:
Code:
$ echo $(x+y)
x+y: command not found

OTOH, if we give it an expr command:
Code:
$ echo $(expr x + y)
expr: non-numeric argument

We need explicit variable expansion:
Code:
$ echo $(expr $x + $y)

BTW, if we want compatibility with older shells that do not support arithmetic expansion, we generally are not going to be able to use new-style command expansion, so we want something like this, instead:

Code:
$ echo `expr $x + $y`
3

we dont conflating anything.we are talking just arithmetic expansion about all shell variants.
I was referring to mentioned syntax of "$((x+y))" expression gives error on the some older shells..
In addition, I mentioned what i identified a issue that is maybe a bug in ash.
because of it(false statement) does not give any error at try of 3rd.

regards
ygemici
Login or Register to Ask a Question

Previous Thread | Next Thread

10 More Discussions You Might Find Interesting

1. Shell Programming and Scripting

Problem with elif and else

Hello experts, I am having problems with ELIF. Please see the below code : read a; read b; read c; if || || ; then echo "EQUILATERAL" elif || || ; then echo "SCALENE" else echo "ISOSCELES" fi This code works fine for the EQUILATERAL case but fails completely for the... (5 Replies)
Discussion started by: H squared
5 Replies

2. Shell Programming and Scripting

If / elif

Hello all, I have a scenario where I take user input values and accordingly take actions say I run a script with sh scriptname -x GB -e txt (txt can also be text) I have used if clause for the first input (-x GB)and it is working fine Now for second the scenario is if then echo... (3 Replies)
Discussion started by: nnani
3 Replies

3. UNIX for Advanced & Expert Users

if else elif

Hi all,i have configured the following script to check if the file exists or not, #!/bin/sh sleep 30 { FILEFULL=$1`date +$2`* if ; then echo $FILEFULL exist else echo "$FILEFULL File not Found" | mail -s 'server' myaccount@mydomain.com fi } but i have a problem, i need to... (2 Replies)
Discussion started by: charli1
2 Replies

4. Shell Programming and Scripting

While-read and if-elif

Hi there, new to this forum and I recently encounter this problem: I tried to use if-elif loop in a while-read loop, something like this: #!/bin/bash while read myline1 myline2 do if ; then echo "Successful!" elif ; then echo "Failed" fi done < $1 Input file looks like this: 200... (13 Replies)
Discussion started by: kennethtls
13 Replies

5. Shell Programming and Scripting

elif if not expected

Hi All, I write an script will have some functions... I am getting elif not expected error.. Even tried by using set -x for debug but no use.. Could you please help me out in this Variables .... .... .... TEST_SRC() { cat ${filesrc} >> ${filetgt} if ]; then echo... (12 Replies)
Discussion started by: kmsekhar
12 Replies

6. Shell Programming and Scripting

If, elif, else statements help

I am in need of some help. I am not an advance scripter or programmer, I have novice knowledge. I cannot get a script to work as expected. The script basically does an FTP (which I have work perfectly) and writes to a log. However, I want the script to echo "Not Connected" if the FTP fails to... (2 Replies)
Discussion started by: anthonyon
2 Replies

7. Shell Programming and Scripting

If -elif-else error.

I am getting below error from this code (which is at line 24): if ] #this is line24 in code then mv $File_source_path/$File_name $File_name'_'`date '+%d%m%y'` Error: line 24: Any help with the syntax. I am putting 2 condition with 'AND' clause. This is bash shell. (2 Replies)
Discussion started by: amit.mathur08
2 Replies

8. Shell Programming and Scripting

Query on If-Elif!!

Script Gurus, Need your help in getting this script to come out of logical error : I have pasted the script below: This script finds disk utilzation ... the script is written for both AIX and SUN OS... and option will be given in the initial to select DB or Non DB... its required for my prj...... (1 Reply)
Discussion started by: vangalli
1 Replies

9. UNIX for Dummies Questions & Answers

Help with ELIF statement

I am receiving an elif error on line 13 and I can not figure out the reasoning behind it. I have added the then statement that I was initially missing. Any help would be great. #The purpose of this script is for the end user to be able to enter a positive number #User enters a number NUM=$1... (4 Replies)
Discussion started by: Brewer27
4 Replies

10. Shell Programming and Scripting

If..elif..else...fi

Hi all, I got some problems on executing the following scripts. Scripts: if ]; then echo "M${str}O 0 1" >> ${tempFile} elif ]; then echo "M${str}O 1 0" >> ${tempFile} else echo "M${str}O 0 0" >> ${tempFile} fi Error: "`;' is not expected." what's the problem? (2 Replies)
Discussion started by: Rock
2 Replies
Login or Register to Ask a Question