The UNIX and Linux Forums  
Hello and Welcome from United States to the UNIX and Linux Forums! Thank You for Visiting and Joining Our Global Community.

Go Back   The UNIX and Linux Forums > Top Forums > High Level Programming
.
google unix.com



High Level Programming Post questions about C, C++, Java, SQL, and other programming languages here.

More UNIX and Linux Forum Topics You Might Find Helpful
Thread Thread Starter Forum Replies Last Post
bash:awk output into an array phamp008 Shell Programming and Scripting 2 03-16-2008 05:14 AM
move output of awk to array amitrajvarma Shell Programming and Scripting 14 12-21-2007 06:12 AM
output of an array ragha81 Shell Programming and Scripting 3 03-22-2007 04:30 PM
directing output Cynergetix UNIX for Dummies Questions & Answers 1 03-21-2002 12:59 PM

Closed Thread
English Japanese Spanish French German Portuguese Italian Dutch Swedish Russian Norwegian Hungarian Hebrew Danish Powered by Powered by Google
 
LinkBack Thread Tools Search this Thread Rate Thread Display Modes
  #1 (permalink)  
Old 04-28-2008
SankarV SankarV is offline
Registered User
  
 

Join Date: Feb 2006
Location: India
Posts: 13
Regardign strtok() output directing to 2-D string array

Hi,


I just wrote a program in C to split a comma seperated string in to group of strings using strtok() function. The code is:

Code:
int main()
{
    char *temp;//not used here but basically we extract one string after another using strtok() and assign to a string pointer defined like this.
    char *str="aa,bb,cc,dd";
    int count=0;
    for(int i=0;i<strlen(str);i++)
    {
      if(str[i]==',')
      count++;
    }

    char *ss[count];//2-d array where i want to store splitted results
    int j=0;
    *(ss+j)=strtok(str,",");

    while(*(ss+j)!=NULL)
    {
      *(ss+j)=strtok(NULL,",");
      j++;
    }
    
    //print  output
    for(int i=0;i<strlen(*ss);i++)
    printf("%s\t",*(ss+i));

    return 0;

}


The program compiles without error(please bear any syntax error, since i typed in hand without the code with me but the orignial program compiles successfully) but i am getting runtime error like 'Segmentation Fault'. I hope there needs to be proper memory handling here which i am not sure of.


Please help me in getting this splitted set of strings to a new 2-D array.


Thanks in advance.
  #2 (permalink)  
Old 04-28-2008
andryk's Avatar
andryk andryk is offline Forum Advisor  
Registered User
  
 

Join Date: Sep 2003
Posts: 448
Quote:
Originally Posted by SankarV View Post
Hi,


I just wrote a program in C to split a comma seperated string in to group of strings using strtok() function. The code is:

Code:
int main()
{
    char *temp;//not used here but basically we extract one string after another using strtok() and assign to a string pointer defined like this.
    char *str="aa,bb,cc,dd";
    char *ss;
    int count=0;
    for(int i=0;i<strlen(str);i++)
    {
      if(str[i]==',')
      count++;
    }

    char *ss[count];//2-d array where i want to store splitted results
    int j=0;
    *(ss+j)=strtok(str,",");

    while(*(ss+j)!=NULL)
    {
      *(ss+j)=strtok(NULL,",");
      j++;
    }
    
    //print  output
    for(int i=0;i<strlen(*ss);i++)
    printf("%s\t",*(ss+i));

    return 0;

}


The program compiles without error(please bear any syntax error, since i typed in hand without the code with me but the orignial program compiles successfully) but i am getting runtime error like 'Segmentation Fault'. I hope there needs to be proper memory handling here which i am not sure of.


Please help me in getting this splitted set of strings to a new 2-D array.


Thanks in advance.
Hi,
Just a little comment after a quick look to your code: i would suggest you to allocate memory properly (using malloc) and not use a shortcut like this
Code:
for(int i=0;i<strlen(str);i++)
    {
      if(str[i]==',')
      count++;
    }

    //char *ss[count];//2-d array where i want to store splitted results
    ss = malloc(count*sizeof(char)); // try this one!
  #3 (permalink)  
Old 04-28-2008
SankarV SankarV is offline
Registered User
  
 

Join Date: Feb 2006
Location: India
Posts: 13
Thanks a ton.

This is working fine now....
  #4 (permalink)  
Old 04-28-2008
andryk's Avatar
andryk andryk is offline Forum Advisor  
Registered User
  
 

Join Date: Sep 2003
Posts: 448
No problem, glad i could help
Closed Thread

Bookmarks

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On




All times are GMT -4. The time now is 05:24 AM.


Powered by: vBulletin, Copyright ©2000 - 2006, Jelsoft Enterprises Limited. Language Translations Powered by .
vBCredits v1.4 Copyright ©2007 - 2008, PixelFX Studios
The UNIX and Linux Forums Content Copyright ©1993-2009. All Rights Reserved.Ad Management by RedTyger

Content Relevant URLs by vBSEO 3.2.0