The UNIX and Linux Forums  


Go Back   The UNIX and Linux Forums > Top Forums > Shell Programming and Scripting
.
google unix.com




View Single Post in the UNIX and Linux Forums - Click on the Thread or Permalink to View Entire Thread -->
  #2 (permalink)  
Old 12-20-2005
reborg's Avatar
reborg reborg is offline Forum Staff  
Administrator
  
 

Join Date: Mar 2005
Location: Ireland
Posts: 4,245
Quote:
Originally Posted by xaphalanx
I'm sure I'm doing something wrong but as I am new to bash shell scripting I'm not sure what:

Here's the code


webalizer.conf is sitting in the same directory as this file which is named webalizer.sh. Can someone tell me if I've got the syntax right -- it that's correct? I'm executing the file as root with sh ./webalizer.sh. webalizer -c file file executes correctly when I manually insert the variable values. The goal is to get this to run through cron.

Thanks!
Your script assumes webalizer is in the path, it may not be for this script; use the full path. Also that is not the correct way to run a script, in this case it will work becasue you've used bourne syntax, but in general using sh will only work correctly for an sh script, make the script executable and run it directly.

Also since this is a launch script I could consider using "exec" at the start of the last line, once it's launched you only need the webalizer process,not the script.