Usually the reason for "-" is that you want the same environment you'd get by logging in as that user, $PATH especially.

Use "-" when you need to know what happens when "sam" logs in: su - sam is going to run sam's shell startup files etc.