Quote:

Originally Posted by llsmr777 Hi thank you for anyone who responds. Here is my script:

Please enclose code in [code] tags. (Edit your original post.)

for i in `ls -1 | grep $1 | grep  $2`

You don't need -1 when the output is not going to a terminal.

You don't need two instances of grep; use grep -e "$1" -e "$2".

You probably don't need ls, either, and it will break you script if any filenames contain spaces.

If you are trying to get files with a certain pattern, use wildcards, e.g.:

Code:

for i in *$1*$2*

do
x=`echo $i | sed 's/\.Sent/\.Done/g'`

You don't need sed:

x=${i%%.Sent*}.Done${i#*.Sent}

echo mv $i DONE/$x
echo "Is this OK?"
read user_response

case $user_response in

"y"|"Y")
        mv $i DONE/$x
        echo mv $i DONE/$x;;
*)
        echo "No changes made ...";;

esac

done

If you don't want to be asked for every file, don't put the question inside the loop. Build a list and present that outside the loop.