I am writing a script and i want to see if this user is on and when they log off. i have some of what i want but not sure if it is right. i think it is just pulling a name from file.

while true
do
if who | grep someone "file"
then break
done

what am I doing wrong?
Please help!